feat(linux-wallpaperengine-controller): improve panel controls, extra properties, and configuration handling#596
Conversation
…sian localization
…d static badge and unit translations
… multiple languages
…update translations for multiple languages
There was a problem hiding this comment.
Pull request overview
This PR improves the wallpaper selection panel’s UX and localization by adding toast feedback for engine actions, expanding translations (including a new Russian locale), and refining panel UI elements (filters, badges, and multi-display targeting).
Changes:
- Add localized toast notifications for reload/stop actions (including “reload skipped”).
- Enhance the panel UI with resolution filtering, clearer badges/labels, and an updated multi-display target selector.
- Expand i18n strings across EN/JA/ZH + add RU, and localize unit suffixes in settings.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| linux-wallpaperengine-controller/Main.qml | Adds optional toast feedback to reload() / stopAll() and imports Toast service. |
| linux-wallpaperengine-controller/BarWidget.qml | Triggers toast-enabled reload/stop from the bar widget context actions. |
| linux-wallpaperengine-controller/Panel.qml | Adds resolution filtering UI, new badges, refactors apply-target UI, and updates empty-state messaging. |
| linux-wallpaperengine-controller/Settings.qml | Localizes FPS/% unit suffixes via translation keys. |
| linux-wallpaperengine-controller/manifest.json | Bumps plugin version to 1.1.0. |
| linux-wallpaperengine-controller/i18n/en.json | Adds toast + new panel strings, updates wording, adds unit strings. |
| linux-wallpaperengine-controller/i18n/ja.json | Adds toast + new panel strings, updates wording, adds unit strings. |
| linux-wallpaperengine-controller/i18n/zh-CN.json | Adds toast + new panel strings, updates wording, adds unit strings. |
| linux-wallpaperengine-controller/i18n/zh-TW.json | Adds toast + new panel strings, updates wording, adds unit strings. |
| linux-wallpaperengine-controller/i18n/ru.json | New full Russian translation coverage including toast + units. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…value handling and UI elements
… for clarity and feature details
…ments for better clarity
|
I think it's pretty good now (current version 1.1.2). |
| { | ||
| "id": "linux-wallpaperengine-controller", | ||
| "name": "Linux WallpaperEngine Controller", | ||
| "version": "1.0.6", |
There was a problem hiding this comment.
version is sus?
the sementic release is normally done with minor and major patches. it looks like you're doing two patches and one minor. when a minor is made in a pr it includes the patches
There was a problem hiding this comment.
I developed this PR iteratively: first a few small fixes, then a larger UI improvement.
I previously conducted multiple rounds of small-scale testing in my personal repository, resulting in multiple version iterations.
I won't change it frequently after that
- Introduced a toggle for enabling an extra properties editor in the settings. - Updated the settings UI to include the new toggle and reorganized some sections for clarity. - Added new translations for the extra properties editor feature in multiple languages. - Implemented a new script to scan wallpaper directories for compatibility with extra properties. - Updated the manifest to include the new configuration option for the extra properties editor.
…nd update related UI elements
…category title in translations
…ompatibility scan logging feat(settings): update default settings handling for volume, mute, audio effects, and mouse/parallax options fix(i18n): update translations for compatibility check messages and search placeholders in multiple languages
Automatic Code Quality ReviewFile: linux-wallpaperengine-controller/Panel.qml
+ label: "", |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spiros132
left a comment
There was a problem hiding this comment.
Some minor feedback about the PR :D
Also it looks like the Panel component has become very huge, I would recommend maybe for the next release to split it up into different components / files to make it easier to read and more organized.
There was a problem hiding this comment.
This one has one more line added and one more line removed. Do double check that the translations match correctly with each other.
There was a problem hiding this comment.
You're right, but since my native language is not a language other than Chinese, the quality of the corresponding translation may not be very good
| clip: true | ||
| spacing: Style.marginS | ||
|
|
||
| GridView { |
There was a problem hiding this comment.
Is it possible to use the noctalia NGridView instead of the qml one? To keep it more consistent with the noctalia look.
There was a problem hiding this comment.
Great, while reviewing the NGridView documentation, I found that card scrolling calculations can also be based on availableWidth, and it's more stable
…ation; update translations for status and reload actions





Summary
What Changed
linux-wallpaperengine --list-propertiesmay failbadgeWhy
linux-wallpaperenginesupports useful runtime flags and property inspection that were not surfaced in the plugin UI.Preview Panel (New):